This repository has been archived by the owner on May 5, 2021. It is now read-only.
Correct animation speed on some of the effects #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 13, 2012 12:48
…ve almost the same as 3.1, but with the animation speed corrected from animSpeed*2 to animSpeed.
Conflicts: jquery.nivo.slider.pack.js
|
@danwood can you expand on what it is you're trying to fix with this? I'm not able to see any speed changes between animations. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to track down why some animation speeds are incorrect, I found several easy fixes, where the animation speed was doubled for some reason. This fixes those ones.
(Still need to figure out how to make the 'fold' one more accurate (it needs to be scaled according to the number of slices, I think) and the various box effects -- Probably need to calculate something about how many total boxes there will be animated and thus how long they will take to animate, and then adjust the actual timings based on that and the desired total animation speed.)
This modification doesn't include the packed javascript file - I couldn't tell what tool you were using to pack your javascript.